Omer Frenkel has posted comments on this change. Change subject: core: Sysprep - Add user specify Active Directory OU ......................................................................
Patch Set 4: (1 comment) backend look ok, minor comment inside http://gerrit.ovirt.org/#/c/26086/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java: Line 89: String inputLocale = Config.<String> getValue(ConfigValues.DefaultSysprepLocale); Line 90: String uiLanguage = Config.<String> getValue(ConfigValues.DefaultSysprepLocale); Line 91: String systemLocale = Config.<String> getValue(ConfigValues.DefaultSysprepLocale); Line 92: String userLocale = Config.<String> getValue(ConfigValues.DefaultSysprepLocale); Line 93: String activeDirectorAU = ""; name should be activeDirectorOU Line 94: Line 95: if (vm.getVmInit() != null) { Line 96: if (!StringUtils.isEmpty(vm.getVmInit().getInputLocale())) { Line 97: inputLocale = vm.getVmInit().getInputLocale(); -- To view, visit http://gerrit.ovirt.org/26086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb63316e8505affd5d78edd90881b2c7cd83e05f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
