Alona Kaplan has uploaded a new change for review. Change subject: webadmin: adding bond status to host interface subtab ......................................................................
webadmin: adding bond status to host interface subtab This patch contains two changes- 1. Adding status icon next to the bond icon. 2. Changing green vlan icon to grey icon to emphasize the icon doesn't represent the vlan status. Change-Id: I32a1f30a4a0668ed38ba3987c9e5dfcfece4ca55 Bug-Url: https://bugzilla.redhat.com/1079719 Bug-Url: https://bugzilla.redhat.com/987299 Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split-rotate.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_down.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_rotate.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_up.png 7 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/26375/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java index d765243..f752daa 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java @@ -154,10 +154,13 @@ @Source("images/search_button.png") ImageResource searchButtonImage(); - @Source("images/split.png") - ImageResource splitImage(); + @Source("images/split_up.png") + ImageResource splitUpImage(); - @Source("images/split-rotate.png") + @Source("images/split_down.png") + ImageResource splitDownImage(); + + @Source("images/split_rotate.png") ImageResource splitRotateImage(); @Source("images/stop.gif") diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java index a6bbe9a..ade78cd 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java @@ -1,5 +1,6 @@ package org.ovirt.engine.ui.webadmin.widget.host; +import org.ovirt.engine.core.common.businessentities.network.InterfaceStatus; import org.ovirt.engine.ui.common.widget.TogglePanel; import org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceLineModel; import org.ovirt.engine.ui.webadmin.gin.ClientGinjectorProvider; @@ -32,7 +33,11 @@ } // Bond icon - add(new Image(ClientGinjectorProvider.getApplicationResources().splitImage())); + if (InterfaceStatus.UP.equals(lineModel.getInterface().getStatistics().getStatus())) { + add(new Image(ClientGinjectorProvider.getApplicationResources().splitUpImage())); + } else { + add(new Image(ClientGinjectorProvider.getApplicationResources().splitDownImage())); + } // Bond name add(new Label(new HostInterfaceBondNameRenderer().render(lineModel))); diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split-rotate.png b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split-rotate.png deleted file mode 100644 index 9cf8a33..0000000 --- a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split-rotate.png +++ /dev/null Binary files differ diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split.png b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split.png deleted file mode 100644 index cddaf61..0000000 --- a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split.png +++ /dev/null Binary files differ diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_down.png b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_down.png new file mode 100644 index 0000000..3804635 --- /dev/null +++ b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_down.png Binary files differ diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_rotate.png b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_rotate.png new file mode 100644 index 0000000..5d7f73a --- /dev/null +++ b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_rotate.png Binary files differ diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_up.png b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_up.png new file mode 100644 index 0000000..4c9fc33 --- /dev/null +++ b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/split_up.png Binary files differ -- To view, visit http://gerrit.ovirt.org/26375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I32a1f30a4a0668ed38ba3987c9e5dfcfece4ca55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
