Eli Mesika has posted comments on this change. Change subject: restapi: Remove dynamic search from VmPool ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26066/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAO.java: Line 127: * @param isFiltered Line 128: * Whether the results should be filtered according to the user's permissions Line 129: * @return a single VM from the pool Line 130: */ Line 131: VM getVmDataFromPoolByPoolName(String vmPoolNam, Guid userID, boolean isFiltered); vmPoolNam => vmPoolName userID => userId http://gerrit.ovirt.org/#/c/26066/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java: Line 214: return getCallsHandler().executeRead("GetVmDataFromPoolByPoolId", VMRowMapper.instance, parameterSource); Line 215: } Line 216: Line 217: @Override Line 218: public VM getVmDataFromPoolByPoolName(String vmPoolNam, Guid userID, boolean isFiltered) { Same comments as in the interface Line 219: MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() Line 220: .addValue("pool_name", vmPoolNam).addValue("user_id", userID).addValue("is_filtered", isFiltered); Line 221: return getCallsHandler().executeRead("GetVmDataFromPoolByPoolName", VMRowMapper.instance, parameterSource); Line 222: } -- To view, visit http://gerrit.ovirt.org/26066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife6adfdca7d32aee3eba6a7e7da49d718ddee60f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
