Liron Ar has posted comments on this change. Change subject: core: proceedStorageDomainTreatmentByDomainType - proper compensation ......................................................................
Patch Set 1: I didn't want to break any pattern, this is the way that this command is written and was written always - as i wrote, locks are the "correct" solution, but the question is whether this scenario is a sufficient trigger for that or not. Adding locks to this flow may cause to deadlocks/side effects on recover across the system and reduce the stability - "ForceRemoveStorageDomainCommand" is a rare case in which the user is being warned about the side effects of his action and being told that it's under his responsibllity so IMO this solution is good In regards to "doesn't mean that you should change an infra." , the infra provided currently in this use case makes assumption on it's use on bll commands which is wrong, when i choose to "compensate" an entity if it was updated doesn't mean that i'll always want to return it in case that it was deleted, this isn't changing the infra but extending it to support more valid usecases like this one and not enforcing different patterns on it's users (which it shouldn't). -- To view, visit http://gerrit.ovirt.org/25232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ec99cf5e567fe9820e4028a886372d73d5c1d6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
