Alon Bar-Lev has posted comments on this change. Change subject: packaging: engine-backup: support dwh and reports ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/25850/6/packaging/bin/engine-backup.sh File packaging/bin/engine-backup.sh: Line 44: def _pythonModulesCompat(): Line 45: \"\"\"Rename modules to match python3 names.\"\"\" Line 46: if sys.version_info[0] >= 3: Line 47: import builtins Line 48: setattr(builtins, 'unicode', str) you do not need to override unicode, so no need to mess up with builtins. Line 49: else: Line 50: import ConfigParser Line 51: sys.modules['configparser'] = ConfigParser Line 52: import __builtin__ Line 47: import builtins Line 48: setattr(builtins, 'unicode', str) Line 49: else: Line 50: import ConfigParser Line 51: sys.modules['configparser'] = ConfigParser only these two lines are important, and the python conditional Line 52: import __builtin__ Line 53: sys.modules['builtins'] = __builtin__ Line 54: Line 55: _pythonModulesCompat() Line 49: else: Line 50: import ConfigParser Line 51: sys.modules['configparser'] = ConfigParser Line 52: import __builtin__ Line 53: sys.modules['builtins'] = __builtin__ you do not need this builtin Line 54: Line 55: _pythonModulesCompat() Line 56: Line 57: import configparser -- To view, visit http://gerrit.ovirt.org/25850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
