Tomas Jelinek has posted comments on this change. Change subject: frontend: added support for attach/detach of instance types ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/25575/13/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PopupWidgetConfig.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PopupWidgetConfig.java: Line 33 Line 34 Line 35 Line 36 Line 37 > hasn't 'markAsSpecial' been used before? or can it safely indicate detachab Well, this field has been implemented as a part of the "first attempt" to introduce instance types and it was meant to mark something as "detachable". Unfortunately for various reasons that effort has not been finished back then and this field stayed here unused. Now as I have started the second attempt to implement the instance types I have just renamed the field (since found a better name) and used it for what it was meant to. -- To view, visit http://gerrit.ovirt.org/25575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4366376750ee4564fa6ff1e42bdfa4a8730d0f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
