Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: grid refresh improvements ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25592/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java: Line 134: Line 135: // Change refresh rate only when the model timer is currently active and not paused Line 136: if (modelTimer.isActive() && !modelTimer.isPaused()) { Line 137: if (inFocus) { Line 138: modelTimer.stop(); Hm, any reason why not add: modelTimer.stop(); before the if block, which is analogous to having: modelTimer.start(); after the if block? Line 139: modelTimer.setRefreshRate(readRefreshRate()); Line 140: } else { Line 141: modelTimer.stop(); Line 142: modelTimer.setRefreshRate(OUT_OF_FOCUS_REFRESH_RATE); -- To view, visit http://gerrit.ovirt.org/25592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d0a2af533285b4248305db3a5e5851d0d004fa0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
