Vojtech Szocs has posted comments on this change.
Change subject: engine: rename gwt-extension.
......................................................................
Patch Set 1:
Two notes on this patch:
* if we want to change gwt-extension project's artifactId to
ovirt-engine-gwt-extension (though I'd prefer just ovirt-gwt-extension), we
should update _all_ references to this artifactId:
frontend/webadmin/modules/pom.xml,
frontend/webadmin/modules/userportal-gwtp/pom.xml,
frontend/webadmin/modules/webadmin/pom.xml
* instead of changing artifactId (which in turn yields lots of changes), why
not just change gwt-extension project's final build name?
I think the BZ was about modifying JAR name as the resulting artifact, so we
can simply do one-line change:
<build>
<!-- overrides default value {artifactId}-${version} -->
<finalName>ovirt-engine-gwt-extension-${version}</finalName>
...
</build>
What do you think?
--
To view, visit http://gerrit.ovirt.org/26045
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53dbae3a56e0a3451c295e05f358a8cc782df4e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
