Eli Mesika has posted comments on this change. Change subject: core: Bookmarks do not work when Search expr... ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25961/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java: Line 166: if (event == null) { Line 167: return; Line 168: } Line 169: treeModelProvider.getModel().setSearchString(StringUtils.EMPTY); Line 170: treeModelProvider.getModel().refresh(); > Would it make sense to move this into the 'TREE_INDEX' part of the switch, No, the empty string should be set for the search expression also when Tags/Bookmarks are selected. If we will not do that we will get exactly to what he BZ described Line 171: switch(event.getSelectedItem()) { Line 172: case TREE_INDEX: Line 173: bookmarkModelProvider.getModel().stopRefresh(); Line 174: tagModelProvider.getModel().stopRefresh(); Line 170: treeModelProvider.getModel().refresh(); Line 171: switch(event.getSelectedItem()) { Line 172: case TREE_INDEX: Line 173: bookmarkModelProvider.getModel().stopRefresh(); Line 174: tagModelProvider.getModel().stopRefresh(); > Oh okay, I figured that this: Yes , this is unique to bookmarks so should not be in tree/tag Line 175: break; Line 176: case BOOKMARK_INDEX: Line 177: treeModelProvider.getModel().stopRefresh(); Line 178: tagModelProvider.getModel().stopRefresh(); Line 180: break; Line 181: case TAG_INDEX: Line 182: treeModelProvider.getModel().stopRefresh(); Line 183: bookmarkModelProvider.getModel().stopRefresh(); Line 184: break; > Oh okay, I figured that this: Yes , this is unique to bookmarks so should not be in tree/tag Line 185: } Line 186: } Line 187: }); Line 188: -- To view, visit http://gerrit.ovirt.org/25961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb9e815e84a2ca1c8a740f7e236d16835ddeeef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
