Alona Kaplan has posted comments on this change.
Change subject: webadmin: localization of spice
......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
Line 2582: key = key.replaceAll("-", "_"); //$NON-NLS-1$ //$NON-NLS-2$
The webadmin gets the keys from the backend (confug_value). The key must be
synchronized with the legal values for spice (and can contain '-'). So in order
to support the gwt Constants keys the '-' must be replace with '_'
--
To view, visit http://gerrit.ovirt.org/4840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e7f4a66128c6903804623497851be119384cb6e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
