Allon Mureinik has uploaded a new change for review. Change subject: findbugs: Clean up Dubious Method warnings ......................................................................
findbugs: Clean up Dubious Method warnings Findbugs' Dubious Method Used warning are about calling methods that would work, but perform the required task inefficiently (e.g., calling new Boolean(true) instead of Boolean.valueOf(true), or even Boolean.TRUE). This patch removes the all-out filter for this category of warnings. Issues previously suppressed by this filter are either fixed where possible, or replaced with a more fine-grained filter where not possible. A notable case where these issues cannot be fixed in is GWT's auto-generated hashCode() methods for classes containing a boolean member. Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M exclude-filters-general.xml M frontend/webadmin/modules/frontend/exclude-filters.xml M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java M frontend/webadmin/modules/webadmin/exclude-filters.xml 7 files changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/26473/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java index 3740f86..66d28b2 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java @@ -292,7 +292,7 @@ protected Long asLong(String id) { try { - return new Long(id); + return Long.valueOf(id); }catch (IllegalArgumentException e) { throw new MalformedIdException(e); } diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java index 2e1cb48..090fcdf 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java @@ -160,7 +160,7 @@ public static Integer tryParse(String text) { try { - return new Integer(text); + return Integer.valueOf(text); } catch (NumberFormatException e) { return null; } diff --git a/exclude-filters-general.xml b/exclude-filters-general.xml index 783bb7b..c13c4d8 100644 --- a/exclude-filters-general.xml +++ b/exclude-filters-general.xml @@ -5,7 +5,7 @@ Dm: Reliance on default encoding (DM_DEFAULT_ENCODING) --> <Match> - <Bug code="Dm" /> + <Bug pattern="DM_DEFAULT_ENCODING" /> </Match> <!-- diff --git a/frontend/webadmin/modules/frontend/exclude-filters.xml b/frontend/webadmin/modules/frontend/exclude-filters.xml index 8f91dd8..ea4d51e 100644 --- a/frontend/webadmin/modules/frontend/exclude-filters.xml +++ b/frontend/webadmin/modules/frontend/exclude-filters.xml @@ -21,7 +21,14 @@ <Bug pattern="UWF_NULL_FIELD"/> </Match> - <!-- + <!-- + Supress inefficient "new Boolean" calls which are generated by GWT + --> + <Match> + <Bug pattern="DM_BOOLEAN_CTOR"/> + </Match> + + <!-- findbugs complains that class is too big of analysis. This class cannot be smaller since it should contain all the errors --> diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml b/frontend/webadmin/modules/gwt-common/exclude-filters.xml index 5b42bcf..8ea48be 100644 --- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml +++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml @@ -93,7 +93,7 @@ <Match> <Class name="org.ovirt.engine.ui.common.presenter.SetDynamicTabAccessibleEvent" /> <Method name="hashCode"/> - <Bug code="DM"/> + <Bug pattern="DM_BOOLEAN_CTOR"/> </Match> <!-- @@ -106,7 +106,7 @@ <Match> <Class name="org.ovirt.engine.ui.common.system.ApplicationFocusChangeEvent" /> <Method name="hashCode"/> - <Bug code="DM"/> + <Bug pattern="DM_BOOLEAN_CTOR"/> </Match> <!-- diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java index f8a4d23..ca9b8f5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/VolumeTransportTypeRenderer.java @@ -33,7 +33,7 @@ transportTypesBuilder.append(", "); //$NON-NLS-1$ } } - return (new String(transportTypesBuilder.toString())); + return transportTypesBuilder.toString(); } } diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml b/frontend/webadmin/modules/webadmin/exclude-filters.xml index 5adcc7f..7805c09 100644 --- a/frontend/webadmin/modules/webadmin/exclude-filters.xml +++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml @@ -236,7 +236,7 @@ <Match> <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.UpdateMainContentLayoutEvent" /> <Method name="hashCode"/> - <Bug code="DM"/> + <Bug pattern="DM_BOOLEAN_CTOR"/> </Match> <!-- -- To view, visit http://gerrit.ovirt.org/26473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b904dfea1991b6ce5bb7c5a534127ee10e56a24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
