Juan Hernandez has posted comments on this change. Change subject: backend: fix username in console connected/disconnected events. ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26456/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 217: final VmDynamic vmDynamic = DbFacade.getInstance().getVmDynamicDao().get(vmId); Line 218: final AuditLogableBase event = new AuditLogableBase(); Line 219: event.setVmId(vmId); Line 220: String username = vmDynamic.getConsoleCurrentUserName(); Line 221: if(username.contains("@")){ > Was it excepted? In this particular case the "consoleCurrentUserName" must contain the @directory suffix, because it is shown in the GUI. This is explicitly assigned in the SetVmTickectCommand, see the "getConsoleUserName()" method there. So I think this patch is correct. Line 222: username = username.substring(0, username.indexOf("@")); Line 223: } Line 224: event.setUserName(username); Line 225: -- To view, visit http://gerrit.ovirt.org/26456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6792cc4bf147dc6eced646b359537ee126341ac9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
