Daniel Erez has posted comments on this change. Change subject: rest: delete a disk from disks collection of a snapshot ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26328/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java: Line 5: Line 6: import javax.ws.rs.core.Response; Line 7: Line 8: public abstract class BackendSnapshotElementsResource<R extends BaseResource> Line 9: extends AbstractBackendCollectionResource<R, Snapshot> { > Do we really need this class? Looks mostly empty, and an obstacle more than Do you mean using AbstractBackendCollectionResource directly? It means we'll have to explicitly implement 'performRemove ' and 'doPopulate' methods in derived classes.. won't it be clearer to keep it? Line 10: Line 11: protected BackendSnapshotResource parent; Line 12: Line 13: protected BackendSnapshotElementsResource(Class<R> modelType, Class<Snapshot> entityType, String... subCollections) { http://gerrit.ovirt.org/#/c/26328/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java: Line 85: } Line 86: Line 87: private void removeDiskSnapshot(Features features) { Line 88: Feature feature = new Feature(); Line 89: feature.setName("Remove disk snapshot"); > Can we put here "Remove disk *from* snapshot" ? And rename the method to "r The functionality is actually removing a snapshot of a disk... but I can change it to removeDiskFromVmSnapshot, which might be clearer, as currently for the user the concept of snapshot is actually a VM snapshot. Line 90: feature.setDescription("Ability to remove a disk from a VM snapshot"); Line 91: features.getFeature().add(feature); Line 92: } Line 93: -- To view, visit http://gerrit.ovirt.org/26328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7fb780516ba715d87e59e98651e9d03dad15845 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
