Kiril Nesenko has posted comments on this change. Change subject: Added scripts for 3.4 to latest upgrade job ......................................................................
Patch Set 19: (4 comments) http://gerrit.ovirt.org/#/c/25989/19/jobs/ovirt-engine_upgrade_stable_to_3.4/build_engine_rpm.sh File jobs/ovirt-engine_upgrade_stable_to_3.4/build_engine_rpm.sh: Line 70: pushd "$src_dir" &>/dev/null Line 71: rm -f ovirt-engine-*.tar.gz Line 72: make dist &> "$dst_dir/make_dist.log" \ Line 73: || return 1 Line 74: [[ -d "$dst_dir" ]] || mkdir -p "$dst_dir" minor, but no need to check if exists, just create it with mkdir -p Line 75: tarball=(ovirt-engine-*.tar.gz) Line 76: [[ -z $tarball ]] || ! [[ -e $tarball ]] \ Line 77: && { Line 78: echo "No tarball created at $src_dir" >&2 Line 149: getopts Just to be as other scripts, please use long options and define get_opts function ? http://gerrit.ovirt.org/#/c/25989/19/jobs/ovirt-engine_upgrade_stable_to_3.4/upgrade.sh File jobs/ovirt-engine_upgrade_stable_to_3.4/upgrade.sh: Line 323: local repos_from=${4?} Line 324: local repos_to=${5?} Line 325: CURRENT_STEP="SETUP" Line 326: ## prepare the logs dir Line 327: [[ -d "$workspace/logs" ]] || mkdir -p "$workspace/logs" just create the directory Line 328: ## Configure all the repos (before the clean so the metadata gets cleaned up) Line 329: configure_repos "$repos_from" "$repos_to" Line 330: ## Make sure no dirty env Line 331: pre_clean "$workspace" "$cleanup_file" Line 333: prepare_database Line 334: ## Make sure apache only listens on localhost, as it collides with Line 335: ## minidell ssh tunnels... Line 336: prepare_apache Line 337: install_from_engine "$setup_file" remove Line 338: collect_iptables_rules "$workspace/logs/iptables_before_upgrade.txt" Line 339: echo "Some yum information" Line 340: yum versionlock list Line 341: yum list installed ovirt-engine\* -- To view, visit http://gerrit.ovirt.org/25989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869ec85c9990677c52ca61549fce4f50f2650f33 Gerrit-PatchSet: 19 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
