Michael Pasternak has posted comments on this change.
Change subject: restapi: Gluster Volume Bricks resource implementation
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2655: <xs:element name="new_stripe_count" type="xs:unsignedShort"
minOccurs="0" maxOccurs="1"/>
please remove 'new_' prefixes
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 45: try {
please use getBackendCollection() instead of this code
Line 103: return
performCreationMultiple(VdcActionType.AddBricksToGlusterVolume,
why you not using performCreation()?, i can't see anything special in
performCreationMultiple(),
note performCreation() has blocking caps.
Line 152: public Response remove(GlusterBricks bricks) {
potential NPE on bricks.getGlusterBricks(), check isSet() first
--
To view, visit http://gerrit.ovirt.org/4909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ab5fc0dd5ef9c2d3eadbc7e78876079c61f46cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
