Yaniv Dary has posted comments on this change. Change subject: reports: br3 report - added comments to queries ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26449/5/packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/br3+full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/br3 full details.jrxml.data: Line 132: FROM v3_4_configuration_history_datacenters Line 133: WHERE Line 134: -- Here we filter by the datacenter chosen by the user Line 135: v3_4_configuration_history_datacenters.datacenter_id = Line 136: CAST ( $P{P_DataCenter_ID} AS uuid ) should be indented by one tab Line 137: AND history_id IN ( Line 138: -- Here we get the latest datacenter configuration Line 139: SELECT MAX ( d.history_id ) Line 140: FROM v3_4_configuration_history_datacenters AS d http://gerrit.ovirt.org/#/c/26449/5/packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data: Line 87: WHERE Line 88: -- Here we filter by the hosts chosen by the user Line 89: $X{ IN, CAST ( v3_4_configuration_history_hosts.host_id AS varchar ), P_Host_ListID } Line 90: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 91: AND history_datetime <= check '=' range Line 92: CASE Line 93: WHEN $P{P_Period} = 0 Line 94: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 95: WHEN $P{P_Period} = 1 Line 123: ) AS a Line 124: RIGHT OUTER JOIN calendar b Line 125: ON ( time = $P!{calendar_column} ) Line 126: WHERE $P!{calendar_column} >= CAST ( $P{P_Start_Date} AS date ) Line 127: AND $P!{calendar_column} <= same Line 128: CASE Line 129: WHEN $P{P_Period} = 0 Line 130: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 131: WHEN $P{P_Period} = 1 -- To view, visit http://gerrit.ovirt.org/26449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68b44f03aba394cbc7d7410d71f38dabccb69355 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
