Alon Bar-Lev has posted comments on this change. Change subject: Split ovirt-release to per version packages. ......................................................................
Patch Set 6: (5 comments) http://gerrit.ovirt.org/#/c/26564/6/ovirt-release-3.4/AUTHORS File ovirt-release-3.4/AUTHORS: we can drop this file, it is not huge project sophisticated and authors can be gotten out of git log. not that important. Line 1: The following people have contributed to this project. Line 2: Line 3: * Ewoud Kohl van Wijngaarden <[email protected]> Line 4: * Kiril Nesenko <[email protected]> http://gerrit.ovirt.org/#/c/26564/6/ovirt-release-3.4/COPYING File ovirt-release-3.4/COPYING: not sure we need this file Line 1: Line 2: Apache License Line 3: Version 2.0, January 2004 Line 4: http://www.apache.org/licenses/ http://gerrit.ovirt.org/#/c/26564/6/ovirt-release-3.4/config/engine-commit-template.txt File ovirt-release-3.4/config/engine-commit-template.txt: please remove these files. Line 1: <core | restapi | tools | history | engine | userportal | webadmin>: short summary under 50 chars (#xxxxxx) Line 2: Line 3: https://bugzilla.redhat.com/XXXXXX Line 4: http://gerrit.ovirt.org/#/c/26564/6/ovirt-release-3.4/glusterfs-epel.repo File ovirt-release-3.4/glusterfs-epel.repo: these should be ovirt-3.4-glusterfs-epel, so we do not have conflict within our packages and between other packages. Line 1: # Place this file in your /etc/yum.repos.d/ directory Line 2: Line 3: [glusterfs-epel] Line 4: name=GlusterFS is a clustered file-system capable of scaling to several petabytes. http://gerrit.ovirt.org/#/c/26564/6/ovirt-release-3.4/ovirt-release34.spec.in File ovirt-release-3.4/ovirt-release34.spec.in: I would have left the spec file without 34, so it will be easier to diff between directories. Line 1: # Line 2: # ovirt-release -- repo files for oVirt projects Line 3: # Copyright (C) 2012-2014 Red Hat, Inc. Line 4: # -- To view, visit http://gerrit.ovirt.org/26564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c2fefb53ac5bac2bea512c573b636a5da1a0aa8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
