Shirly Radco has posted comments on this change. Change subject: reports: br7b report - added comments to queries ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/25237/5/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b+full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/br7b full details.jrxml.data: Line 106: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 month' - interval '1 day' AS date) Line 107: WHEN $P{P_Period} = 2 Line 108: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '3 month' - interval '1 day' AS date) Line 109: WHEN $P{P_Period} = 3 Line 110: THEN CAST ( CAST($P{P_Start_Date} AS date ) + interval '1 year' - interval '1 day' AS date) > drop lines here. Done Line 111: END AS end_date, Line 112: ( Line 113: SELECT DISTINCT Line 114: COALESCE ( http://gerrit.ovirt.org/#/c/25237/5/packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data File packaging/ovirt-reports/resources/Reports/Service_level/Hosts/top_10_downtime_hosts_br7b_files/top_10_downtime_hosts_br7b_jrxml.data: Line 95: AS uptime_mins, Line 96: SUM ( Line 97: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status Line 98: ) AS total Line 99: FROM v3_4_statistics_hosts_resources_usage_$P!{table_name} > Change to shorter table name using AS. Done Line 100: INNER JOIN v3_4_configuration_history_hosts Line 101: ON ( Line 102: v3_4_configuration_history_hosts.host_id = Line 103: v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_id Line 165: CASE Line 166: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 1 Line 167: THEN Line 168: COALESCE ( Line 169: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 > split to two lines per parameter Done Line 170: ) Line 171: ELSE 0 Line 172: END Line 173: ) / 60 Line 181: CASE Line 182: WHEN v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_status = 3 Line 183: THEN Line 184: COALESCE ( Line 185: v3_4_statistics_hosts_resources_usage_$P!{table_name}.minutes_in_status, 0 > split to two lines per parameter Done Line 186: ) Line 187: ELSE 0 Line 188: END Line 189: ) -- To view, visit http://gerrit.ovirt.org/25237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If15e13abe907bcdfb903d02aab049f262d7bf350 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
