Shirly Radco has posted comments on this change.

Change subject: reports: edited ic query-only_vms_dc
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26302/1/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_DataCenter_ID.xml
File 
packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/P_DataCenter_ID.xml:

Line 73:         WHERE enum_translator_default.language_code = 'en_US'
Line 74:             AND enum_translator_default.enum_type =
Line 75:                 'REPORTS_REMOVED_ON'
Line 76:     ) AS loc_removed_on
Line 77:     ON ( 0 = 0 )
> Should be indented by one more.
Done
Line 78: WHERE
Line 79:     -- Here we filter datacenters that have vms.
Line 80:     datacenter_id IN (
Line 81:         SELECT DISTINCT datacenter_id


-- 
To view, visit http://gerrit.ovirt.org/26302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6135679f7324e4594c9fce94592b1ec6a2508f0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <[email protected]>
Gerrit-Reviewer: Shirly Radco <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to