Shirly Radco has posted comments on this change. Change subject: reports: br5 report - added comments to queries ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/26445/2/packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7+full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/br7 full details.jrxml.data: Line 116: ) Line 117: END AS end_date, Line 118: ( Line 119: SELECT DISTINCT Line 120: COALESCE ( > this is over indented by one tab. Done Line 121: enum_translator_localized.value_localized, Line 122: enum_translator_default.value Line 123: ) Line 124: FROM enum_translator AS enum_translator_default Line 120: COALESCE ( Line 121: enum_translator_localized.value_localized, Line 122: enum_translator_default.value Line 123: ) Line 124: FROM enum_translator AS enum_translator_default > same Done Line 125: LEFT OUTER JOIN ( Line 126: SELECT Line 127: enum_type, Line 128: enum_key, http://gerrit.ovirt.org/#/c/26445/2/packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/five_least_utilized_hosts_br5_files/five_least_utilized_hosts_br5_jrxml.data: Line 111: ) Line 112: WHERE Line 113: v3_4_statistics_hosts_resources_usage_$P!{table_name}.history_datetime >= Line 114: CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 115: AND v3_4_statistics_hosts_resources_usage_$P!{table_name}.history_datetime <= > Please check the time range here. In both lines there is a '=' looks good to me. Line 116: CASE Line 117: WHEN $P{P_Period} = 0 Line 118: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 119: WHEN $P{P_Period} = 1 Line 159: THEN b.host_type Line 160: ELSE $P{P_Host_Type} Line 161: END Line 162: AND a.history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 163: AND a.history_datetime <= > trialing whitespace and same comment on range '=' Done Line 164: CASE Line 165: WHEN $P{P_Period} = 0 Line 166: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 167: WHEN $P{P_Period} = 1 Line 222: a.time = b.$P!{calendar_column} Line 223: ) Line 224: WHERE $P!{calendar_column} >= CAST($P{P_Start_Date} AS date) Line 225: AND $P!{calendar_column} <= Line 226: CASE > not indented correctly. also '=' same. Done Line 227: WHEN $P{P_Period} = 0 Line 228: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 229: WHEN $P{P_Period} = 1 Line 230: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 month' -- To view, visit http://gerrit.ovirt.org/26445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie771e476688c5dfc2bf432c11f96631db2b1a658 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
