Shirly Radco has posted comments on this change. Change subject: reports: br2b report - added comments to queries ......................................................................
Patch Set 3: (18 comments) http://gerrit.ovirt.org/#/c/26450/3/packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/br2+full+details.jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/br2 full details.jrxml.data: Line 126: CAST ( v3_4_configuration_history_datacenters.delete_date AS date ) Line 127: FROM v3_4_configuration_history_datacenters Line 128: WHERE Line 129: v3_4_configuration_history_datacenters.datacenter_id = Line 130: CAST ( $P{P_DataCenter_ID} AS uuid ) > should be indented by one tab. Done Line 131: AND history_id IN ( Line 132: SELECT MAX ( d.history_id ) Line 133: FROM v3_4_configuration_history_datacenters AS d Line 134: GROUP BY d.datacenter_id http://gerrit.ovirt.org/#/c/26450/3/packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data File packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_usage_dow_br2b_files/single_host_resource_usage_dow_br2b.data: Line 90: FROM v3_4_statistics_hosts_resources_usage_$P!{table_name} Line 91: WHERE Line 92: -- Here we filter by the host chosen by the user Line 93: v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_id = Line 94: CASE $P{P_Host_ID} > should be indented by one more tab Done Line 95: WHEN '00000000-0000-0000-0000-000000000000' Line 96: THEN '00000000-0000-0000-0000-000000000000' Line 97: WHEN NULL Line 98: THEN '00000000-0000-0000-0000-000000000000' Line 100: THEN '00000000-0000-0000-0000-000000000000' Line 101: ELSE CAST ($P{P_Host_ID} AS uuid) Line 102: END Line 103: AND history_datetime >= CAST ( $P{P_Start_Date} AS date ) Line 104: AND history_datetime <= > '=' in both Done Line 105: CASE Line 106: WHEN $P{P_Period} = 0 Line 107: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 108: WHEN $P{P_Period} = 1 Line 117: ) AS a Line 118: RIGHT OUTER JOIN calendar Line 119: ON ( $P!{calendar_column} = time ) Line 120: WHERE $P!{calendar_column} >= CAST ( $P{P_Start_Date} AS date ) Line 121: AND $P!{calendar_column} <= > same '=' Done Line 122: CASE Line 123: WHEN $P{P_Period} = 0 Line 124: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 125: WHEN $P{P_Period} = 1 Line 178: SELECT DISTINCT Line 179: -- Here we the day of week (DOW) AS the day number. Line 180: EXTRACT ( DOW FROM $P!{calendar_column} ) AS day_num, Line 181: day_name, Line 182: AVG (VMS) AS VMS, > Should be: Done Line 183: AVG (VMS_Peak) AS VMS_Peak Line 184: FROM ( Line 185: SELECT Line 186: history_datetime AS time, Line 203: FROM v3_4_statistics_hosts_resources_usage_$P!{table_name} Line 204: WHERE Line 205: -- Here we filter by the host chosen by the user Line 206: v3_4_statistics_hosts_resources_usage_$P!{table_name}.host_id = Line 207: CASE $P{P_Host_ID} > should be indented by one more tab Done Line 208: WHEN '00000000-0000-0000-0000-000000000000' Line 209: THEN '00000000-0000-0000-0000-000000000000' Line 210: WHEN NULL Line 211: THEN '00000000-0000-0000-0000-000000000000' Line 213: THEN '00000000-0000-0000-0000-000000000000' Line 214: ELSE CAST ($P{P_Host_ID} AS uuid) Line 215: END Line 216: AND history_datetime >= CAST ( $P{P_Start_Date} AS date ) Line 217: AND history_datetime <= > '=' in both Done Line 218: CASE Line 219: WHEN $P{P_Period} = 0 Line 220: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 221: WHEN $P{P_Period} = 1 Line 230: ) AS a Line 231: RIGHT OUTER JOIN calendar Line 232: ON ( $P!{calendar_column} = time ) Line 233: WHERE $P!{calendar_column} >= CAST ( $P{P_Start_Date} AS date ) Line 234: AND $P!{calendar_column} <= > same Done Line 235: CASE Line 236: WHEN $P{P_Period} = 0 Line 237: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 238: WHEN $P{P_Period} = 1 Line 293: EXTRACT ( DOW FROM $P!{calendar_column} ) AS day_num, Line 294: day_name, Line 295: COALESCE ( Line 296: interface_name, Line 297: MAX ( interface_name ) over ( partition by 1 ), '' ) > please place ')' in separate row Done Line 298: AS interface_name, Line 299: AVG ( Rx_rate ) AS Rx_rate, Line 300: AVG (Tx_rate) AS Tx_rate Line 301: FROM ( Line 294: day_name, Line 295: COALESCE ( Line 296: interface_name, Line 297: MAX ( interface_name ) over ( partition by 1 ), '' ) Line 298: AS interface_name, > over indented by one tab Done Line 299: AVG ( Rx_rate ) AS Rx_rate, Line 300: AVG (Tx_rate) AS Tx_rate Line 301: FROM ( Line 302: SELECT Line 336: THEN '00000000-0000-0000-0000-000000000000' Line 337: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 338: END Line 339: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 340: AND history_datetime <= > '=' in ranges. Done Line 341: CASE Line 342: WHEN $P{P_Period} = 0 Line 343: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 344: WHEN $P{P_Period} = 1 Line 361: ON ( c.host_interface_id = b.host_interface_id ) Line 362: WHERE Line 363: -- Here we filter by the host chosen by the user Line 364: c.host_id = Line 365: CASE $P{P_Host_ID} > should be indented by one more tab Done Line 366: WHEN '00000000-0000-0000-0000-000000000000' Line 367: THEN '00000000-0000-0000-0000-000000000000' Line 368: WHEN NULL Line 369: THEN '00000000-0000-0000-0000-000000000000' Line 369: THEN '00000000-0000-0000-0000-000000000000' Line 370: WHEN '11111111-1111-1111-1111-111111111111' Line 371: THEN '00000000-0000-0000-0000-000000000000' Line 372: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 373: END > align this row to tabs Done Line 374: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 375: AND history_datetime <= Line 376: CASE Line 377: WHEN $P{P_Period} = 0 Line 371: THEN '00000000-0000-0000-0000-000000000000' Line 372: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 373: END Line 374: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 375: AND history_datetime <= > same '=' Done Line 376: CASE Line 377: WHEN $P{P_Period} = 0 Line 378: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 379: WHEN $P{P_Period} = 1 Line 372: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 373: END Line 374: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 375: AND history_datetime <= Line 376: CASE > should be indented by one more tab Done Line 377: WHEN $P{P_Period} = 0 Line 378: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 379: WHEN $P{P_Period} = 1 Line 380: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 month' Line 411: RIGHT OUTER JOIN calendar AS b Line 412: ON ( a.time = b.$P!{calendar_column} ) Line 413: WHERE Line 414: b.$P!{calendar_column} >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 415: AND b.$P!{calendar_column} <= > check '=' Done Line 416: CASE Line 417: WHEN $P{P_Period} = 0 Line 418: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 419: WHEN $P{P_Period} = 1 Line 531: THEN '00000000-0000-0000-0000-000000000000' Line 532: ELSE CAST ( $P{P_Host_ID} AS uuid ) Line 533: END Line 534: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 535: AND history_datetime <= > same Done Line 536: CASE Line 537: WHEN $P{P_Period} = 0 Line 538: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 539: WHEN $P{P_Period} = 1 Line 548: ) AS a Line 549: RIGHT OUTER JOIN calendar Line 550: ON ( $P!{calendar_column} = time ) Line 551: WHERE $P!{calendar_column} >= CAST ( $P{P_Start_Date} AS date ) Line 552: AND $P!{calendar_column} <= > same Done Line 553: CASE Line 554: WHEN $P{P_Period} = 0 Line 555: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 556: WHEN $P{P_Period} = 1 -- To view, visit http://gerrit.ovirt.org/26450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibccaba25b0ffefd7d24fd8b446bb1f74caff9296 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
