Ori Liel has posted comments on this change.
Change subject: restapi: Import VM more than once
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 178: <xs:element name="import_as_new_entity" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
The name shouldn't be so long, I suggest 'clone'.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 726: optionalArguments: {action.storage_domain.id|name:
'xs:string', action.vm.snapshots.collapse_snapshots: 'xs:boolean',
action.import_as_new_entity: 'xs:boolen', action.vm.disks.disk--COLLECTION:
{id: 'xs:string'}}
again, change name (I suggest to 'clone')
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
Line 47: if (action.isSetImportAsNewEntity()) {
name will change....
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
Line 191: new String[] {
"ContainerId", "StorageDomainId", "SourceDomainId", "DestDomainId",
"StoragePoolId", "VdsGroupId", "CopyCollapse", "ImportAsNewEntity" },
name...
--
To view, visit http://gerrit.ovirt.org/4940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf4d95c0408af532faa4db022fc9c8a5912a3f09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
