Alon Bar-Lev has posted comments on this change. Change subject: Split ovirt-release to per version packages. ......................................................................
Patch Set 11: (5 comments) much better! http://gerrit.ovirt.org/#/c/26564/11/ovirt-release-3.4/Makefile.am File ovirt-release-3.4/Makefile.am: Line 27: Line 28: dist_pkgdata_DATA = \ Line 29: $(srcdir)/ovirt-el-deps.repo.in \ Line 30: $(srcdir)/ovirt-el-deps.repo \ Line 31: $(srcdir)/ovirt-f19-deps.repo.in \ I think autoconf will do this automatically. Line 32: $(srcdir)/ovirt-f19-deps.repo \ Line 33: $(srcdir)/ovirt.repo.in \ Line 34: $(srcdir)/ovirt.repo \ Line 35: $(NULL) http://gerrit.ovirt.org/#/c/26564/11/ovirt-release-3.4/configure.ac File ovirt-release-3.4/configure.ac: Line 24: define([VERSION_SUFFIX], [_master]) Line 25: define([OVIRT_VERSION_MAJOR], [3]) Line 26: define([OVIRT_VERSION_MINOR], [4]) Line 27: define([OVIRT_VERSION_FIX], [0]) Line 28: define([OVIRT_VERSION_NUMBER], OVIRT_VERSION_MAJOR[.]OVIRT_VERSION_MINOR[.]OVIRT_VERSION_FIX) OVIRT_RELEASE ? Line 29: Line 30: AC_INIT([ovirt-release34], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 31: Line 32: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 30: AC_INIT([ovirt-release34], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) Line 31: Line 32: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 33: PACKAGE_RPM_RELEASE="0.1.$(echo VERSION_SUFFIX | sed 's/^_//')" Line 34: OVIRT_VERSION="OVIRT_VERSION_NUMBER" this should be OVIRT_SLOT or similar as this is not the version (no z), or just remove the z from OVIRT_VERSION Line 35: AC_SUBST([PACKAGE_RPM_VERSION]) Line 36: AC_SUBST([PACKAGE_RPM_RELEASE]) Line 37: AC_SUBST([OVIRT_VERSION]) Line 38: Line 43: Makefile Line 44: ovirt-release.spec Line 45: ovirt.repo Line 46: ovirt-f19-deps.repo Line 47: ovirt-el-deps.repo please sort() Line 48: ]) http://gerrit.ovirt.org/#/c/26564/11/ovirt-release-3.4/ovirt-release.spec.in File ovirt-release-3.4/ovirt-release.spec.in: Line 89: %ghost %config(noreplace) %{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}.repo Line 90: %ghost %config(noreplace) %{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo Line 91: Line 92: %changelog Line 93: * Thu Apr 10 2014 Kiril Nesenko <[email protected]> - - -- To view, visit http://gerrit.ovirt.org/26564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c2fefb53ac5bac2bea512c573b636a5da1a0aa8 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
