Lior Vernia has posted comments on this change. Change subject: frontend: Remove deprecated Editors ......................................................................
Patch Set 3: I haven't had the time to investigate thoroughly, but I think this patch might have introduced several regressions (I have stumbled upon one which I think is a result of this). In StorageModel you changed the privateName member to be generic, but didn't change the corresponding nameEditor in StoragePopupView to be generic, which causes events relay between the model and editor to malfunction (specifically in that dialog the name field keeps showing up as empty even though text is input). Please go over the patch again and fix this and other possible glitches... -- To view, visit http://gerrit.ovirt.org/26475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0640e68540e34fb1e020c6fcd59b5438d52dfdd9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
