Alon Bar-Lev has posted comments on this change. Change subject: Split ovirt-release to per version packages. ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/26564/13/ovirt-release-3.4/Makefile.am File ovirt-release-3.4/Makefile.am: Line 27: Line 28: dist_pkgdata_DATA = \ Line 29: $(srcdir)/ovirt-el-deps.repo \ Line 30: $(srcdir)/ovirt-f19-deps.repo \ Line 31: $(srcdir)/ovirt.repo \ hmmm.... why do you distribute these generated files? now I noticed you removed the in... but there is no need to distribute anything, just remove this dist_ prefix, make sure no generated files are within make dist tarball. Line 32: $(NULL) Line 33: Line 34: http://gerrit.ovirt.org/#/c/26564/13/ovirt-release-3.4/configure.ac File ovirt-release-3.4/configure.ac: Line 24: define([VERSION_SUFFIX], [_master]) Line 25: define([OVIRT_VERSION_MAJOR], [3]) Line 26: define([OVIRT_VERSION_MINOR], [4]) Line 27: Line 28: AC_INIT([ovirt-release34], VERSION_NUMBER[]VERSION_SUFFIX, [[email protected]]) why don't you use the above defines to construct the 34? Line 29: Line 30: PACKAGE_RPM_VERSION="VERSION_NUMBER" Line 31: PACKAGE_RPM_RELEASE="0.1.$(echo VERSION_SUFFIX | sed 's/^_//')" Line 32: OVIRT_SLOT="OVIRT_VERSION_MAJOR.OVIRT_VERSION_MINOR" -- To view, visit http://gerrit.ovirt.org/26564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c2fefb53ac5bac2bea512c573b636a5da1a0aa8 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
