Simone Tiraboschi has posted comments on this change. Change subject: WIP: packaging: setup: iSCSI support ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/26501/4/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 475: ) Line 476: def ISCSI_TARGET(self): Line 477: return 'OVEHOSTED_STORAGE/iSCSITargetName' Line 478: Line 479: ISCSI_PASSWORD = 'OVEHOSTED_STORAGE/iSCSIPortalPassword' Do we also need to manage target serial and auth method for custom setup? Line 480: Line 481: Line 482: @util.export Line 483: @util.codegen http://gerrit.ovirt.org/#/c/26501/4/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py File src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py: Line 99: caseSensitive=True, Line 100: default=ohostedcons.Defaults.DEFAULT_ISCSI_PORT, Line 101: ) Line 102: try: Line 103: if int(port) > 0: It's probably also a good idea to check that port number is <= 65535 Line 104: valid = True Line 105: else: Line 106: raise ValueError(_('Port must be a valid port number')) Line 107: except ValueError as e: Line 328: self.command.get('iscsiadm'), Line 329: '-m', Line 330: 'discovery', Line 331: '-t', Line 332: 'sendtargets', Is it enough to handle all the authentication mechanism variants? Line 333: '-p', Line 334: '{address}:{port}'.format( Line 335: address=address, Line 336: port=port, Line 340: ) Line 341: if rc == 0: Line 342: valid_access = True Line 343: for line in stdout: Line 344: valid_targets.append(line.split()[1]) Do we also need to try a login on every listed target to be sure that they are really valid? Line 345: else: Line 346: self.logger.error(_('Cannot access to iSCSI portal')) Line 347: for line in stderr: Line 348: self.logger.error(line) -- To view, visit http://gerrit.ovirt.org/26501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide79a130b730d95d3545dcfb80b1b01dfeaf2b12 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
