Allon Mureinik has posted comments on this change. Change subject: core: Introducing HttpImageTaskVDSCommand ......................................................................
Patch Set 1: Code-Review+1 (1 comment) No tests? http://gerrit.ovirt.org/#/c/26674/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadStreamVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UploadStreamVDSCommandParameters.java: Line 6: Line 7: public class UploadStreamVDSCommandParameters extends ImageHttpAccessVDSCommandParameters { Line 8: private InputStream inputStream; Line 9: Line 10: public UploadStreamVDSCommandParameters(Guid vdsId, Guid storagePoolId, Guid storageDomainId, Guid imageGroupId, Guid imageId, Long size, InputStream inputStream) { why not use long? can it ever be null? Line 11: super(vdsId, storagePoolId, storageDomainId, imageGroupId, imageId, size); Line 12: this.inputStream = inputStream; Line 13: } Line 14: -- To view, visit http://gerrit.ovirt.org/26674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc9284e62f75cc4958909bcb03c9b4fa8e30d7d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
