Selvasundaram has posted comments on this change.
Change subject: engine: Reducing replica count feature in Remove brick
......................................................................
Patch Set 1: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 64: return validateBricks(getParameters().getBricks());
There is no Stripe count parameter to change. Stripe count validation is not
required.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 740: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Replica count can be reduced 1 at a time.
Done
Line 741: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_REPLICA_COUNT=Cannot ${action}
${type}. Replica count can not be increased.
Done
Line 742: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT=Cannot ${action}
${type}. Replica count can not be reduced.
Done
Line 743:
ACTION_TYPE_FAILED_CAN_NOT_INCREASE_REPLICA_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Replica count can be increased 1 at a time.
Done
Line 744: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_STRIPE_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Stripe count can be increased 1 at a time.
Done
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
Line 1915: @DefaultStringValue("Cannot ${action} ${type}. Replica count can
be reduced 1 at a time.")
Done
--
To view, visit http://gerrit.ovirt.org/4970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e10d79f3b6e014b62b139c74762cb0cab72d5fc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
