Juan Hernandez has posted comments on this change. Change subject: rest: retrieve disk snapshots list by storage domain ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26730/2/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskSnapshotsResourceTest.java: Line 37: Line 38: @Override Line 39: @Test Line 40: @Ignore Line 41: public void testQuery() throws Exception { Please, either implement or remove these empty tests. Line 42: } Line 43: Line 44: @Test Line 45: @Override http://gerrit.ovirt.org/#/c/26730/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskSnapshotMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskSnapshotMapper.java: Line 4: import org.ovirt.engine.api.model.DiskSnapshot; Line 5: import org.ovirt.engine.api.restapi.utils.GuidUtils; Line 6: import org.ovirt.engine.core.common.businessentities.DiskImage; Line 7: Line 8: public class DiskSnapshotMapper extends DiskMapper { I don't see any benefit in extending DiskMapper. Line 9: Line 10: @Mapping(from = org.ovirt.engine.core.common.businessentities.Disk.class, to = DiskSnapshot.class) Line 11: public static DiskSnapshot map(org.ovirt.engine.core.common.businessentities.Disk entity, DiskSnapshot template) { Line 12: if (template == null) { -- To view, visit http://gerrit.ovirt.org/26730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5359c5df490c7e7e6f9b4d25e794bd07c6877339 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
