Martin Peřina has uploaded a new change for review. Change subject: tools: Fix LDAP servers issue in engine-manage-domains ......................................................................
tools: Fix LDAP servers issue in engine-manage-domains LDAP servers discovered using DNS query will not be written to database (they will be rediscovered using DNS query when needed). LDAP servers entered in --ldap-servers argument will be always written to database (they will be used then and no LDAP DNS discovery will be executed). Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Bug-Url: https://bugzilla.redhat.com/1084479 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/26861/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java index a19e0f4..afd0fa4 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java @@ -544,7 +544,9 @@ adUserPasswordEntry.setValueForDomain(domainName, getPasswordInput()); authModeEntry.setValueForDomain(domainName, authMode); ldapProviderTypesEntry.setValueForDomain(domainName, ldapProviderType.name()); - setLdapServersPerDomain(domainName, ldapServersEntry, StringUtils.join(ldapServers, ",")); + if (args.contains(ARG_LDAP_SERVERS)) { + setLdapServersPerDomain(domainName, ldapServersEntry, StringUtils.join(ldapServers, ",")); + } handleChangePasswordMsg(domainName, changePasswordUrlEntry, false); testConfiguration(domainName, domainNameEntry, -- To view, visit http://gerrit.ovirt.org/26861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ab5bd3a27787615c7430ce2f3a120261f4cd300 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
