Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API in built-in authz and auth ......................................................................
Patch Set 22: I think all these should be moved to builtin extensions or not used, or duplicated with simple classes (Pair). Logging should use commons-logging directly. We left with the following which should be moved to own jar. org.ovirt.engine.core.utils.cli.ArgumentBuilder; org.ovirt.engine.core.utils.cli.ExtendedCliParser; And this, not sure if we can avoid? adding values directly into the vdc_options? org.ovirt.engine.core.utils.db.DbUtils; org.ovirt.engine.core.utils.db.StandaloneDataSource; --- $ find ./backend/manager/modules/builtin-extensions/ -name '*.java' | xargs grep 'import ' | grep 'ovirt\.engine\.core' | sed 's/.*import //' | sort | uniq org.ovirt.engine.core.aaa.NegotiationResult; org.ovirt.engine.core.common.businessentities.LdapGroup; org.ovirt.engine.core.common.businessentities.LdapUser; org.ovirt.engine.core.common.config.Config; org.ovirt.engine.core.common.config.ConfigValues; org.ovirt.engine.core.common.errors.VdcBllMessages; org.ovirt.engine.core.common.utils.EnumUtils; org.ovirt.engine.core.common.utils.Pair; org.ovirt.engine.core.compat.Guid; org.ovirt.engine.core.ldap.LdapProviderType; org.ovirt.engine.core.ldap.LdapSRVLocator; org.ovirt.engine.core.utils.cli.ArgumentBuilder; org.ovirt.engine.core.utils.cli.ExtendedCliParser; org.ovirt.engine.core.utils.collections.DomainsPasswordMap; org.ovirt.engine.core.utils.db.DbUtils; org.ovirt.engine.core.utils.db.StandaloneDataSource; org.ovirt.engine.core.utils.dns.DnsSRVLocator; org.ovirt.engine.core.utils.dns.DnsSRVLocator.DnsSRVResult; org.ovirt.engine.core.utils.EngineLocalConfig; org.ovirt.engine.core.utils.ipa.ReturnStatus; org.ovirt.engine.core.utils.ipa.SimpleAuthenticationCheck; org.ovirt.engine.core.utils.kerberos.AuthenticationResult; org.ovirt.engine.core.utils.kerberos.KDCLocator; org.ovirt.engine.core.utils.kerberos.KerberosConfigCheck; org.ovirt.engine.core.utils.kerberos.KerberosReturnCodeParser; org.ovirt.engine.core.utils.kerberos.KerberosUtils; org.ovirt.engine.core.utils.kerberos.KrbConfCreator; org.ovirt.engine.core.utils.log.Log; org.ovirt.engine.core.utils.log.Log4jUtils; org.ovirt.engine.core.utils.log.LogFactory; org.ovirt.engine.core.utils.MockConfigRule; org.ovirt.engine.core.utils.ReflectionUtils; static org.ovirt.engine.core.common.config.ConfigValues.AdUserId; static org.ovirt.engine.core.common.config.ConfigValues.AdUserName; static org.ovirt.engine.core.common.config.ConfigValues.AdUserPassword; static org.ovirt.engine.core.common.config.ConfigValues.ChangePasswordMsg; static org.ovirt.engine.core.common.config.ConfigValues.DomainName; static org.ovirt.engine.core.common.config.ConfigValues.LDAPProviderTypes; static org.ovirt.engine.core.common.config.ConfigValues.LDAPSecurityAuthentication; static org.ovirt.engine.core.common.config.ConfigValues.LDAPServerPort; static org.ovirt.engine.core.common.config.ConfigValues.LdapServers; static org.ovirt.engine.core.utils.MockConfigRule.mockConfig; -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
