Lior Vernia has posted comments on this change. Change subject: webadmin: Have minus button on every row in AddRemoveRowWidget ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26879/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java: Line 200: if (!last.hasPrevious()) { // just a precaution; if there's no item, there should be no button Line 201: return; Line 202: } Line 203: Line 204: if (item == last.previous() && last.hasPrevious()) { // add plus button to previous item > ok, now I'm picky but the last.hasPrevious() is redundant here since you ha Are you sure? I think last.previous() decrements the iterator, and then last.hasPrevious() checks if there exists a previous item (second to last). That, at least, was my intention. Line 205: Pair<T, V> previousItem = last.previous(); Line 206: getEntry(previousItem.getSecond()).appendButton(createButton(previousItem, true)); Line 207: } Line 208: -- To view, visit http://gerrit.ovirt.org/26879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6af3c5a94f7786a9b1e6191f1c36d3181983cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
