Lior Vernia has posted comments on this change. Change subject: engine: findbugs warning ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/26986/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java: Line 88: if (getClass() != obj.getClass()) { Line 89: return false; Line 90: } Line 91: ServerCpu other = (ServerCpu) obj; Line 92: return ObjectUtils.objectsEqual(privateArchitecture, other.privateArchitecture) Note that enums can be compared as primitives using the == operator. For your consideration if you prefer this or that (I know my preference, but I won't force it on you). Line 93: && ObjectUtils.objectsEqual(privateCpuName, other.privateCpuName) Line 94: && ObjectUtils.objectsEqual(privateFlags, other.privateFlags) Line 95: && privateLevel == other.privateLevel Line 96: && ObjectUtils.objectsEqual(privateVdsVerbData, other.privateVdsVerbData); -- To view, visit http://gerrit.ovirt.org/26986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25f0be9e319aec078fadabfa426d1e4b7c170493 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
