Liron Ar has posted comments on this change. Change subject: core: DiskImagesValidator - validate images belong to same Disk ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26448/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java: Line 191: Line 192: return ValidationResult.VALID; Line 193: } Line 194: Line 195: public ValidationResult diskImagesBelongToSameImageGroup() { perhaps you can return more informative message here to the user so he can know what was his mistake more easily, as we should already have all the information queried it's preferred imo (something like:) Cannot ${action} ${type}. The specified disks snapshots don't belong to the same Disk (Disk snapshot/Disk belong to); asdasd (Disk1, id:43430343) ... i'm added something similar here - http://gerrit.ovirt.org/#/c/26262/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java Line 196: Guid imageGroupId = null; Line 197: for (DiskImage diskImage : diskImages) { Line 198: if (imageGroupId == null || diskImage.getId().equals(imageGroupId)) { Line 199: imageGroupId = diskImage.getId(); -- To view, visit http://gerrit.ovirt.org/26448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c4a31cbe3d93f582b710910dd9cd1a51ab50b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
