Omer Frenkel has posted comments on this change. Change subject: core: Grayed-Out LUNs Support ......................................................................
Patch Set 11: (5 inline comments) if you add new fields to lun entity you need to populate it everywhere it is used, means new view for luns with domains and disk (id and name) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java Line 47: storagePool.getcompatibility_version().compareTo(Version.v3_1) < 0; you should use the backward compatibility infrastructure that uses configuration. Line 67: List<storage_domains> domainsList = storageDomainDAO.getAll(); please add a db query to get domains by vg (storage) Line 79: lun.setLunDisk(lunsFromDbById.containsKey(lun.getLUN_id()) && lun.getStorageDomainId() != null); i think it should be == instead of != and what about luns that are shared between domains and disks .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java Line 297: private boolean lunDisk; why boolean and not disk id and name? .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java Line 29: getParameters().getcompatibility_version().compareTo(Version.v3_1) < 0; you should use the backward compatibility infrastructure that uses configuration. -- To view, visit http://gerrit.ovirt.org/4858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
