Sandro Bonazzola has posted comments on this change.

Change subject: aaa: introducing the new extension api
......................................................................


Patch Set 44:

@Alon Bar-Lev

 > please review the spec changes. what I like to do is to 
 > have "virtual" for programs to depend on based on api 
 > version.

I've reviewed the spec file and I think it may be ok as-is.
However, looking at other API packages for mvn related things I see they also 
provides other targets.
This one ofr example has API version in package name:

 # rpm -q --provides jboss-jsf-2.1-api-2.0.2-6.fc19.noarch
 jboss-jsf-2.1-api = 2.0.2-6.fc19
 mvn(javax.faces:jsf-api) = 2.0.2.Final
 mvn(org.jboss.spec.javax.faces:jboss-jsf-api_2.1_spec) = 2.0.2.Final
 osgi(org.jboss.spec.javax.faces.jboss-jsf-api_2.1_spec) = 2.0.2

while this one hasn't:
 # rpm -q --provides weld-api
 mvn(org.jboss.weld:weld-api) = 1.1.Final
 mvn(org.jboss.weld:weld-api-bom) = 1.1.Final
 mvn(org.jboss.weld:weld-api-parent) = 1.1.Final
 mvn(org.jboss.weld:weld-spi) = 1.1.Final
 weld-api = 1.1-7.fc19

I'm not sure if it's koji that add them, but maybe you want to take a look at 
them too.

-- 
To view, visit http://gerrit.ovirt.org/26435
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d70daf5e1fc7875458d9091cc814de817223aa0
Gerrit-PatchSet: 44
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to