Mike Kolesnik has posted comments on this change. Change subject: webadmin: Add gateway & DNS servers fields ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25359/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 447: Line 448: boolean subnetValid = true; Line 449: if ((Boolean) getExport().getEntity()) { Line 450: boolean dnsServersListed = false; Line 451: for (EntityModel<String> dnsServer : getSubnetModel().getDnsServers().getItems()) { > This validation should be part of ExternalSubnetModel.validate() and not he Done Line 452: dnsServersListed |= StringUtils.isNotEmpty(dnsServer.getEntity()); Line 453: } Line 454: Line 455: if (StringUtils.isNotEmpty(getSubnetModel().getName().getEntity()) -- To view, visit http://gerrit.ovirt.org/25359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c958328e769badebe2d95359d3ae81e657205c2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
