Mike Kolesnik has posted comments on this change.
Change subject: core: Failed to activate host on 3.0 cluster (#828970)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 1071: if (network.get("bridged") != null) {
Why even try extract the value here, and not only if the compatibility version
matches?
Line 1076: if (DbFacade.getInstance()
This is quite ugly, consider using ConfigValue instead.
See for reference any config value ending with Enabled.
--
To view, visit http://gerrit.ovirt.org/5081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dd846340ea15454e582be44e6249f4eda888843
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
