Roy Golan has posted comments on this change. Change subject: core: [monitoring] process hardware caps before software ......................................................................
Patch Set 4: Verified+1 (1 comment) also verified creating a cluster with no architecture, no cpu, no emulated machine . activating works and sets all arch, cpu emulated machine to appropriate values http://gerrit.ovirt.org/#/c/26284/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 369 Line 370 Line 371 Line 372 Line 373 > can you explain why you remove this? to avoid calling processHardwareCaps again in afterRefreshTreatment - simply redundent -- To view, visit http://gerrit.ovirt.org/26284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b0b7ff7d751c3c617f6ac1e794582346f81706e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
