Oved Ourfali has posted comments on this change. Change subject: core: Add config values for host kdump detection ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/27199/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1718: /** Line 1719: * Defines minimum timeout allowed between one kdump flow finished and new one started for one host (seconds) Line 1720: */ Line 1721: @TypeConverterAttribute(Integer.class) Line 1722: @DefaultValueAttribute("60") I guess we would want a bigger timeout here, won't we? Line 1723: NextKdumpTimeout, Line 1724: Line 1725: /** Line 1726: * Defines the interval between messages sent by fence_kdump_send (seconds) Line 1732: /** Line 1733: * Defines the IP address to receive fence_kdump messages on Line 1734: */ Line 1735: @TypeConverterAttribute(String.class) Line 1736: @DefaultValueAttribute("") By default do we have the listener or not? (don't remember what we decided on). If we do, don't we want to have some "localhost" as default? Line 1737: FenceKdumpListenerHost, Line 1738: Line 1739: /** Line 1740: * Defines the port to receive fence_kdump messages on -- To view, visit http://gerrit.ovirt.org/27199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4451719415958b21aa421105f4154db4afc755c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
