Mike Kolesnik has posted comments on this change. Change subject: engine: Adjust NetworkUtils to accept any vlan device name- phase 1 ......................................................................
Patch Set 6: (1 comment) The agile approach is very good, just a small comment in the code and also a question: In phase 2 do you intend to fix the tests to use the new signatures? http://gerrit.ovirt.org/#/c/26608/6/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java: Line 40: } Line 41: return StringUtils.stripEnd(sb.toString(), "."); Line 42: } Line 43: Line 44: // method returns underlying interface name: Can you please document with javadoc? Line 45: // if the interface is not vlan returns the interface name Line 46: public static String stripVlan(VdsNetworkInterface nic) { Line 47: return NetworkUtils.isVlan(nic) ? nic.getBaseInterface() : nic.getName(); Line 48: } -- To view, visit http://gerrit.ovirt.org/26608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426159c169b1fa478776abafb38cb7ae6fdac3be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
