Vojtech Szocs has posted comments on this change.

Change subject: webadmin: Filter search objects according to main model 
availability
......................................................................


Patch Set 2:

Yeah, I got it now :-) this was quite tricky.

The problem is, main model default search strings 
(SearchableListModel.getDefaultSearchString) and search object suggestions 
(both singular, like "Template", and plural, like "Templates") are totally 
unrelated, and this causes these issues.

For example, TemplateListModel.getDefaultSearchString returns "Template". But 
SearchSuggestModel offers "Templates" for when starting to type "T" into search 
bar. We need to consolidate this stuff.

--
To view, visit http://gerrit.ovirt.org/5036
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibcd3026a0b2fb6ce9bbd19613a4ff42cac034f43
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to