Keith Robertson has posted comments on this change. Change subject: Avoid silent success of ISO uploading ......................................................................
Patch Set 2: Do not submit You aren't considering the fact that multiple files can be uploaded at one time. As it stands now, you'll see the same line printed multiple times. You need to print the name of the file (preferred) or move where this information is printed. Finally, I'm on the fence about the utility of this because the exit code for the program is properly set. "cp" doesn't report that it successfully copied a file. -- To view, visit http://gerrit.ovirt.org/4554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied68defb80af61a3dddf0c95eecc6d1352166cda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Shu Ming <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
