Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: fix log messages in AsyncTaskBase ......................................................................
Patch Set 1: (6 comments) http://gerrit.ovirt.org/#/c/27283/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskBase.java: Line 193: Line 194: catch (RuntimeException e) { Line 195: log.error( Line 196: String.format( Line 197: "AsyncTaskBase::PollAndUpdateTask: Handling task '%1$s' (State: %2$s, Parent Command: %3$s, Parameters Type: %4$s) threw an exception", I'll be glad if we can remove the prefix of the class name, as we can see - this is misleading. no need for that. Line 198: getVdsmTaskId(), Line 199: getState(), Line 200: (getParameters().getDbAsyncTask() Line 201: .getaction_type()), Line 243: Line 244: protected void RemoveTaskFromDB() { Line 245: try { Line 246: if (coco.removeByVdsmTaskId(getVdsmTaskId()) != 0) { Line 247: log.infoFormat("AsyncTaskBase::RemoveTaskFromDB: Removed task {0} from DataBase", getVdsmTaskId()); same. Line 248: } Line 249: } Line 250: Line 251: catch (RuntimeException e) { Line 249: } Line 250: Line 251: catch (RuntimeException e) { Line 252: log.error(String.format( Line 253: "AsyncTaskBase::RemoveTaskFromDB: Removing task %1$s from DataBase threw an exception.", same Line 254: getVdsmTaskId()), e); Line 255: } Line 256: } Line 257: Line 273: } Line 274: Line 275: protected void LogEndTaskSuccess() { Line 276: log.infoFormat( Line 277: "AsyncTaskBase::OnTaskEndSuccess: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended successfully.", same Line 278: getVdsmTaskId(), Line 279: (getParameters().getDbAsyncTask().getaction_type()), Line 280: getParameters() Line 281: .getClass().getName()); Line 287: } Line 288: Line 289: protected void LogEndTaskFailure() { Line 290: log.errorFormat( Line 291: "AsyncTaskBase::LogEndTaskFailure: Task '{0}' (Parent Command {1}, Parameters Type {2}) ended with failure:" same. Line 292: + "\r\n" + "-- Result: '{3}'" + "\r\n" + "-- Message: '{4}'," + "\r\n" + "-- Exception: '{5}'", Line 293: getVdsmTaskId(), Line 294: (getParameters().getDbAsyncTask().getaction_type()), Line 295: getParameters() Line 306: } Line 307: Line 308: protected void LogTaskDoesntExist() { Line 309: log.errorFormat( Line 310: "AsyncTaskBase::LogTaskDoesntExist: Task '{0}' (Parent Command {1}, Parameters Type {2}) does not exist.", same. Line 311: getVdsmTaskId(), Line 312: (getParameters().getDbAsyncTask().getaction_type()), Line 313: getParameters() Line 314: .getClass().getName()); -- To view, visit http://gerrit.ovirt.org/27283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id625b80bbe1d5968250136e8184a4250c5f63155 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
