Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix UpdateVmDiskCommand resize validation ......................................................................
core: Fix UpdateVmDiskCommand resize validation validateCanResizeDisk() is called from UpdateVmDiskCommand CDA and is faulty. In it the first two verifications were called whether there was an attempt to resize the image or not. These two verifications now take place only if there is indeed an attempt to resize the image. Need to add a mock in the test. Change-Id: I760bb3b72d872a1ba5c7af2a9607c7249583652a Bug-Url: https://bugzilla.redhat.com/1092087 Bug-Url: https://bugzilla.redhat.com/1092371 Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 18 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/27271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I760bb3b72d872a1ba5c7af2a9607c7249583652a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
