Yair Zaslavsky has posted comments on this change. Change subject: coverity: Fix INVALIDATE_ITERATOR warning in SessionDataContainer ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27275/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java: Line 144: */ Line 145: @OnTimerMethodAnnotation("cleanExpiredUsersSessions") Line 146: public final void cleanExpiredUsersSessions() { Line 147: Date now = new Date(); Line 148: Iterator<Entry<String, SessionInfo>> iter = sessionInfoMap.entrySet().iterator(); Not with concurrent map, we checked it. In one of the rounds I worked on the code, I suggested to use iterator due to the exact reason, but Alonbl showed me that with concurrent map it does not happen. Line 149: while (iter.hasNext()) { Line 150: Entry<String, SessionInfo> entry = iter.next(); Line 151: ConcurrentMap<String, Object> sessionMap = entry.getValue().contentOfSession; Line 152: Date hardLimit = (Date) sessionMap.get(HARD_LIMIT_PARAMETER_NAME); -- To view, visit http://gerrit.ovirt.org/27275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I223c41e0ad0c091532e598f281f0679306f1164c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
