Yair Zaslavsky has posted comments on this change. Change subject: aaa: Rename Authentication filter ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27284/1/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/NegotiationAuthnFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/NegotiationAuthnFilter.java: Line 114: } Line 115: Line 116: caps = 0; Line 117: for (String nego : req.getServletContext().getInitParameter(INTERACTIVE_NEGOTIATION_PARAMETER).split(",")) { Line 118: if (nego.equals("interactive")) { > bitwise or of all IMHO, i should read the init variable and use it where i'm filling the profile list - at findNegotiationProfiles. Line 119: caps |= Authn.Capabilities.AUTHENTICATE_NEGOTIATE_INTERACTIVE; Line 120: } else if (nego.equals("non-interactive")) { Line 121: caps |= Authn.Capabilities.AUTHENTICATE_NEGOTIATE_NON_INTERACTIVE; Line 122: } -- To view, visit http://gerrit.ovirt.org/27284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee6d0c5805e4509f4011dd9ebc994fba0f419f55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
