Sharad Mishra has posted comments on this change.
Change subject: core: adding logging to Migration logic
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1279: log.debugFormat("removing VM {0} from
from succesful run VMs list", vmToUpdate.getId());
just a nit - "from from".
and also if you redo this patch, can you try to limit to 80 chars per line?
Line 1354: log.infoFormat("VM moved from {0} --> {1}",
vmToUpdate.getstatus().name(), runningVm.getstatus().name());
Again, if possible 80 chars per line.
--
To view, visit http://gerrit.ovirt.org/5098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8ac3e78366570a1fc6d4d7e882e36b68ee9917
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
