Tal Nisan has posted comments on this change.

Change subject: core: Permission filtering for GetAllVmTemplates query. 
(#783087)
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File backend/manager/dbscripts/vm_templates_sp.sql
Line 231:                                           WHERE  user_id = v_user_id 
AND entity_id = vmt_guid))
The indentation of the WHERE clause? We have used this kind of indentation 
throughout the queries

--
To view, visit http://gerrit.ovirt.org/5104
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78b5078dcdcfcf01a6b95f444975b2d8c75996cc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to