Adam Litke has posted comments on this change. Change subject: Adding support in CPU monitoring ......................................................................
Patch Set 6: Code-Review-1 (3 comments) Getting close... Just a few minor nits left. http://gerrit.ovirt.org/#/c/27240/6/mom/HypervisorInterfaces/vdsmInterface.py File mom/HypervisorInterfaces/vdsmInterface.py: Line 170: response = vm.getStats() Line 171: self._check_status(response) Line 172: """ Line 173: Get user selection for vCPU limit Line 174: """ Why are you using docstrings for inline comments? Just do: # Get user selection for vCPU limit Line 175: user_cpu_tune_info = response['statsList'][0]['userCpuTuneInfo'] Line 176: ret.update(user_cpu_tune_info) Line 177: """ Line 178: Get current vcpu tuning info Line 175: user_cpu_tune_info = response['statsList'][0]['userCpuTuneInfo'] Line 176: ret.update(user_cpu_tune_info) Line 177: """ Line 178: Get current vcpu tuning info Line 179: """ ditto Line 180: cpu_tune_info = response['statsList'][0]['cpuTuneInfo'] Line 181: ret.update(cpu_tune_info) Line 182: """ Line 183: Get num of vCPUs Line 180: cpu_tune_info = response['statsList'][0]['cpuTuneInfo'] Line 181: ret.update(cpu_tune_info) Line 182: """ Line 183: Get num of vCPUs Line 184: """ ditto Line 185: vcpuCount = response['statsList'][0]['cpu_cpunt'] Line 186: if vcpuCount == None: Line 187: return None Line 188: else: -- To view, visit http://gerrit.ovirt.org/27240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31428499ae7b34cafa3eacf5ca0d7a39eabe23ec Gerrit-PatchSet: 6 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
